https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41788
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #14 from Emily Lamancusa (emlam) <[email protected]> --- For context - this is expanding bug 36455 into something that takes 15 lines of code and a system preference, compared to 2-3 lines of JQuery that were being used to accomplish the same thing before 36455. On the one hand, we do value bringing common things into core rather than having libraries duplicate customizations; on the other hand, I wanted to at least ask the question of whether it still makes sense to have this feature in core when it means maintaining code that has become that much more complex than the JQuery it's replacing, or whether it makes more sense to revert 36455. That said, I'm also not excited to revert a community contribution to bring a common JQuery customization into core that has already been in 2 releases, and the prevailing sentiment on the Mattermost thread seems to be in favor of keeping it and adding the syspref, so I'm leaning towards going ahead with this if there aren't any major objections. I originally asked on Mattermost and not here because I was afraid if I only asked here, it wouldn't get seen and this bug would stall in In Discussion forever. Probably should have posted here first and then linked on Mattermost, sorry. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
