https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
--- Comment #359 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 194087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194087&action=edit Bug 10190: (QA follow-up) Fix six issues reported during QA 1. Letter context: setFilteredLetters() was reading library_id from currentRuleSet (which has no top-level library_id property) instead of this.context.library_id, causing library-specific letter templates to never match. 2. False conflict on edit: conflict check fetched rule set from DB with effective=false (raw), but the in-memory snapshot was fetched with effective=true (with fallbacks). Comparing raw vs effective always triggered a conflict when a context inherited any value from a more general rule. Fixed by using effective=true for the DB fetch too. 3. Incomplete deletion: updateCircRuleSets() inside deleteRuleSet() was called without await, creating a race condition where the page refresh could complete before the deletion API call, leaving stale data visible. Also added a guard to skip rule sets with no explicit rules for the trigger being deleted, and simplified rulesForDeletion construction. 4. No rules displayed on initial load: the route watcher in CirculationTriggersList fired immediately before init() had loaded patron categories and item types, causing setAllExhaustiveEffectiveRuleSets() to produce an empty result. Fixed with a metaInitialized flag that the watcher waits for before proceeding. 5. DefaultToLoggedInLibraryOverdueTriggers syspref not respected: the default_view template variable was computed but never applied to the store's currentLibraryId. Fixed by passing it to init(). 6. UI colors: info box background changed from #84c1f3 to #DAECFB (lighter, matching the circulation rules page). Error alert messages changed from alert-info (blue) to alert-warning (yellow) to match Koha conventions. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
