https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41269
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <[email protected]> --- git grep get_user_subpermissions C4/Auth.pm: get_all_subpermissions get_cataloguing_page_permissions get_user_subpermissions in_iprange C4/Auth.pm: my $user_subperms = get_user_subpermissions($userid); C4/Auth.pm:=head2 get_user_subpermissions C4/Auth.pm: $user_perm_hashref = get_user_subpermissions($userid); C4/Auth.pm:sub get_user_subpermissions { C4/Auth.pm:has the same structure as that of C<get_user_subpermissions>, about.pl:use C4::Auth qw( get_template_and_user get_user_subpermissions ); about.pl: my $all_permissions = C4::Auth::get_user_subpermissions($borrowernumber); members/member-flags.pl:use C4::Auth qw( get_template_and_user get_all_subpermissions get_user_subpermissions ); members/member-flags.pl: my $user_perms = get_user_subpermissions( $bor->{'borrowernumber'} ); It looks like you forgot some places. I do agree that it is more logical to look for borrowernumber btw, although we often tend to keep the parameters of such longstanding routines the same. Note that plugins and customizations etc might use them too and will need attention locally. So this needs to be communicated clearly and should stand out in the release notes. Perhaps add an additional dbrev to print a warn. Or just keep the userid? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
