https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41310
--- Comment #18 from David Cook <[email protected]> --- (In reply to Saiful Amin from comment #17) > (In reply to David Cook from comment #14) > > The test plan is missing the steps for upgrading the database and restarting > > services but that's ok. Not a blocker. > > Sorry I missed that! I'll add now. Thanks :) > > I don't know about having "ActionLogsEnableIPLogging" under "Debugging" > > instead of "Logging", > > I did consider placing it under "Logging", but it seemed the odd one out. > Whereas, placing it next to 'ActionLogsTraceDepth' felt more logical. Yeah, no big deal either way. All good. > > So I should be able to signoff once you move > > Koha/Schema/Result/ActionLog.pm > > to a separate patch, and address those FAILs in the QA test results. They > > should be pretty easy to do. Let me know if you need help with any of those. > > I'll need help with this. Is it two separate commits in same patch or a > follow-up patch? I'd say neither. You'll want to split the commit into 2 commits and attach them as 2 separate patches. So the one with Koha/Schema/Result/ActionLog.pm would have a title like "Bug 41310: Schema changes (do not push)". The release manager Lucas explains this a bit more at https://chat.koha-community.org/koha-community/pl/gah7x4txiigbdc15a518kzbnxy For example, look at bug 36506. the final patch there is "Bug 36506: DO NOT PUSH - SCHEMA UPDATES". -- If you wanted to go even further you could separate the "installer/data/mysql/atomicupdate/bug_41310-add_ip_address_to_action_logs.pl", "installer/data/mysql/kohastructure.sql", and "installer/data/mysql/mandatory/sysprefs.sql" into a "Database update" patch, but that's not strictly necessary. The schema updates being separated IS strictly necessary though. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
