https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42020

            Bug ID: 42020
           Summary: (Bug 39482 follow-up) Library info link shown in OPAC
                    without OpacLibraryInfo and library URL
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

Prior to Bug 39482 a link to library info modal (with (i) icon) was generated
only if OpacLibraryInfo was defined. Now it is there even if there is no
OpacLibraryInfo at all and no URL defined for the library. It is generated in
any circumstances.

(BTW this makes the following snippet from opac-detail.tt dead:

[% ELSIF holding_library_url %]
    <a href="[% holding_library_url | url %]"> [% holding_library_name | html
%] </a>
[% ELSE %]
    <span>[% holding_library_name | html %]</span>
[% END %]
)

This is because Koha::Library::opac_info returns a RS now, and not an object,
as it was before. 

So a test on $item->holding_branch->opac_info( { lang => $lang } ) in
opac-detail.pl returns always true.


To reproduce:
1) Have a standard ktd installation.
2) Make sure there is no OpacLibraryInfo defined in HTML customizations.
3) Make sure there is no URL for any library. 
4) In OPAC, perform any search. On a detail page you would see a link to an
empty modal from the Current library items column.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to