https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42029

            Bug ID: 42029
           Summary: Add diff support to RECALLS action logs
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Transaction logs
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]
            Blocks: 37940

The action logging for the RECALLS module (Koha/Recall.pm) currently logs
status-change actions (OVERDUE, EXPIRE, CANCEL, FILL) with simple string
messages such as 'Recall status set to overdue'. These calls do not pass the
$original parameter to logaction(), so no structured diff is generated in the
action_logs.diff column.

This bug covers updating the four logaction() calls in Koha/Recall.pm to pass
the pre-change recall state as the sixth argument ($original), enabling
before/after comparison in the action log viewer.

Affected calls:
- RECALLS/OVERDUE (Koha/Recall.pm ~line 437)
- RECALLS/EXPIRE  (Koha/Recall.pm ~line 454)
- RECALLS/CANCEL  (Koha/Recall.pm ~line 470)
- RECALLS/FILL    (Koha/Recall.pm ~line 486)

Since Koha::Recall is a Koha::Object subclass, $self->unblessed can be captured
before the status change and passed as $original.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940
[Bug 37940] [OMNIBUS] All modification logged via action logs should include
original to create JSON diff
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to