https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42031
Bug ID: 42031
Summary: Add diff support to serial subscription action logs
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Transaction logs
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Blocks: 37940
The action logging in C4/Serials.pm for subscription changes passes an empty
string as the info parameter for all logged actions (MODIFY, ADD, RENEW,
DELETE). No structured diff is generated in the action_logs.diff column.
Affected calls in C4/Serials.pm:
- SERIAL/MODIFY (~line 1410): logaction( "SERIAL", "MODIFY", $subscriptionid,
"" )
- SERIAL/ADD (~line 1534): logaction( "SERIAL", "ADD", $subscriptionid,
"" )
- SERIAL/RENEW (~line 1636): logaction( "SERIAL", "RENEW", $subscriptionid,
"" )
- SERIAL/DELETE (~line 1859): logaction( "SERIAL", "DELETE", $subscriptionid,
"" )
This bug covers updating these calls to pass meaningful subscription data.
Ideally the C4::Serials functions should be refactored to use
Koha::Subscription objects so that $subscription->unblessed can be passed as
$infos and $original. At a minimum, a subscription hashref retrieved before the
change should be passed as $original and the post-change state as $infos.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940
[Bug 37940] [OMNIBUS] All modification logged via action logs should include
original to create JSON diff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
