https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604
--- Comment #20 from Jason Robb <[email protected]> --- These are the steps I took to verify table column settings were taking priority when hiding columns, while also demonstrating that syspref-controlled columns that aren't configurable in table settings continue to display correctly. This likely doesn't cover everything. Everything was done as the superlibrarian unless otherwise noted. Setup before testing: 1.) Set permissions & login for Henry - catalogue (staff access) - edit_patrons (in tools) 2.) Set system preferences so columns display in various places - ClaimReturnedLostValue: Lost (or other non-null value) - ExportCircHistory: Enable - EDIFACT: Enable - CancelOrdersInClosedBaskets: Enable - AllowHoldItemTypeSelection: Enable Check current behaviors: --Checkouts table (circulation & moremember)-- 1.) Check an item out to Henry 2.) Note the "Check in" and "Return claims" columns are visible 3.) Click "Configure" in the upper right of the table to get to table settings 4.) Check "Is hidden by default" for "checkin" and "claims_returned" 5.) Uncheck "Save configuration state on page change" (this can cause inconsistent/confusing behavior when testing) 6.) Save table settings 7.) Return to Henry's checkout screen, note those two columns are still visible 8.) Repeat steps 2-6 on Henry's Details page 9.) Navigate back to Henry's Details page, note those two columns are still visible --Holds history table-- 1.) Place a hold on a record for Henry 2.) Go to Henry's "Holds history" tab 3.) Note the "Requested item type" column 4.) Click "Configure" in the upper right of the table to get to table settings 5.) Check "Is hidden by default" for "itemtype" 6.) Uncheck "Save configuration state on page change" 7.) Save table settings 8.) Return to Henry's Holds history page, note the column is still visible --Orders table in baskets-- 1.) Add an EDI account a.) Administration > EDI accounts > New account > Submit 2.) Add an item to the existing basket a.) Acquisitions b.) Search "My vendor" c.) Click "1 basket(s)" > "My Basket" d.) Add to basket e.) Choose "From new (empty) record" > Add item > Save 3.) Note the "Supplier report" column 4.) Close the basket 5.) Note the "Supplier report" column 6.) Click "Configure" in the upper right of the table to get to table settings 7.) Check "Is hidden by default" for "supplier_report" 8.) Uncheck "Save configuration state on page change" 9.) Save 10.) Go back to the basket, note the "Supplier report" column 11.) Reopen the basket, note the "Supplier report" column --Patron batch modification table-- Note: The table settings seem to overtake permissions before the patch is applied. Logged in as Henry: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) Note the absence of the "Password expiration date" and "Protected" columns 4.) Note the checkbox column on the left 5.) Click Save 6.) Note the absence of the checkbox column on the left Logged in as superlibrarian: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) Note the "Password expiration date" and "Protected" columns 4.) Click "Configure" in the upper right of the table to get to table settings 5.) Check "Is hidden by default" for "batch_patron_edit_password_expiration_date" and "batch_patron_edit_protected" 6.) Uncheck "Save configuration state on page change" 7.) Repeat 1-2, columns are hidden 8.) Note the checkbox column on the left 9.) Click Save 10.) Note the absence of the checkbox column on the left ---> APPLY THE PATCH <--- Check new behaviors: --Checkouts table (circulation & moremember)-- 1.) Pull up Henry's circulation page 2.) "Check in" and "Return claims" columns should be hidden 3.) Pull up Henry's Details page 4.) "Check in" and "Return claims" columns should be hidden 5.) Unhide columns in the table settings and verify they display again --Holds history table-- 1.) Pull up Henry's Holds history page 2.) "Requested item type" column should be hidden 3.) Unhide column in the table settings and verify it displays again --Orders table in baskets-- 1.) Pull up the basket 2.) "Supplier report" column should be hidden 3.) Close the basket 4.) "Supplier report" column should be hidden 5.) Unhide column in the table settings and verify it displays again --Patron batch modification table-- Logged in as Henry: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) "Password expiration date" and "Protected" should still be hidden 4.) Note the checkbox column on the left 5.) Click Save 6.) Note the absence of the checkbox column on the left <-- currently not working, see comment 18 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604#c18) 7.) Unhide columns in the table settings and verify they are still hidden (Henry doesn't have permission to see them) <-- currently not working, see comment 19 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604#c19) Log in as superlibrarian: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) "Password expiration date" and "Protected" should still be hidden 4.) Note the checkbox column on the left 5.) Click Save 6.) Note the absence of the checkbox column on the left <-- currently not working, see comment 18 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604#c18) 7.) Unhide columns in the table settings and verify they display again -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
