https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141
Jan Kissig <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Jan Kissig <[email protected]> --- > ... > I don't think this bug should introduce "inconsistencies" for SIP, when > compared to the ERM module: > - Save: For ERM, saves and shows details vs SIP where there are two > different behavours (stays on the page, and doesn't return to the list x 1 > occurrence, vs 2 occurrences where they return to the list) > - Save and show: not used by the ERM mdoule, this is the "Save" behavour > (also not used before this patch is applied) > > For most of the ERM module (excluding eUsage forms): > - Save: saves and shows details (stays on the page, and doesn't return to > the list) > - Save and continue editing: stays on the form and lets you continue editing > - Save and return to list: saves any changes and returns to the list > > Because of the inconsistencies, I left as Failed QA. > > Hope this makes sense (have been looking at this for too long!). > > David Hi David, I can understand the little confusion with the action behind the 'Save' button as it could mean either 'Save and show', 'Save and continue editing' or 'Save an show list' but is always labeled 'Save', though the alternative save buttons behind the drop down have their actions clearly labeled. As for the different behaviors introduced in this patch: With bug 40191 a new property (navigationOnFormSave) gives the developer exactly this option to control which action should be taken on the default 'Save' click. There is also some info in the coding guidelines now: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS18:_Vue_resource_design_pattern As in sip2 the configurations for 'Institutions' and 'Syspref overrides' are not so complicated (having only a few options to be set) I choose to return to the list on after saving. But for the 'Accounts', with its many options to be set, I thought it would be nice to see what I just entered after save. As this patch fixes the functionality behind the button I would remove the FQA and set it SO. The default action behind that 'Save' button can be changed on a different bug -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
