https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38338
--- Comment #61 from David Cook <[email protected]> --- (In reply to Olivier Hubert from comment #60) > Yes, I agree that all this is possible and the way to go. The problem I see > is that the SMTP server configuration, and so eventually the web > authentication, is / will be done through smtp_server.pl. If we allow that > page to configure the Transport and not the SMTP::Server instance, then we > are forever coupling Transport::OAUTH and SMTP::Server. In that case, I > don't really see the need to have a separate entity for Transport::OAUTH if > it needs to always work in conjunction with SMTP::Server. > > I think you have summed up pretty well how will work, with a cronjob for the > refresh token, etc. I'm just curious as to why we need two separate classes > if we're linking them so deeply. I might be trying to solve a non-issue. I'm > not sure how the relationship between different classes is managed. Honestly, I think it's "six of one and half a dozen of another". Since it's all backend, I don't think it really matters, as we can always change things if necessary. I think Tomas's transport idea would be cleaner, but it's not critical I think. For now, I think the most important thing is just getting something that works. The perfect is the enemy of the good. I don't know why I'm so full of English idioms today. I'm going to query one of my libraries to see how they're going getting some credentials, so I can test this out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
