https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795

--- Comment #8 from Victor Grousset/tuxayo <[email protected]> ---
Comment on attachment 196366
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196366
Bug 40795: Fix +add note function on payment table

Review of attachment 196366:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40795&attachment=196366)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
@@ +243,5 @@
>      </div>
>      <!-- /.toptabs -->
>  [% END %]
> +<!-- Edit note modal -->
> +<div class="modal" id="editNoteModal" tabindex="-1" role="dialog" 
> aria-labelledby="editNoteLabel">

I'm not sure but comparing with
https://wiki.koha-community.org/wiki/Interface_patterns#Modals
It seems there should be `aria-hidden="true"`
Is it so assistive technologies understand that the modal isn't visible on page
load?
Once it's there, aria-hidden should be changed automatically when opening or
closing the modal. Must be something in bootstrap.

There are other differences with the interface pattern page but I don't know if
they are relevant.

@@ +280,5 @@
> +            <!-- /.modal-content -->
> +        </div>
> +        <!-- /.modal-dialog -->
> +    </form>
> +    <!-- /#void_form -->

Seems it should be #edit_form

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to