https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789

Kyle M Hall (khall) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #41 from Kyle M Hall (khall) <[email protected]> ---
(In reply to Pedro Amorim from comment #36)
> Hi Kyle, I want to PQA but, even though my initial comments were addressed,
> this:
> 1) Lacks a reproducible test plan
> 2) Lacks new unit tests for the new config options it's adding

Yeah, a test plan requires the use of a proxy, so non-trivial to set up. I
think the new unit tests are sufficient to show it works!


> 3) Adds a new config option that is 'on' by default?

It was permanently on previously, so this is a new feature to allow it to be
turned 'off'!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to