http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565
Liz Rea <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Liz Rea <[email protected]> --- One weirdness: http://img716.imageshack.us/img716/7357/rgya.png The add patron button looks a bit strange here. I wonder if you could just go with the word "Add" ? Nice to have, but not required to have (future maybe?) - add a borrower to a list from their detail or circulation screen (in the more menu perhaps?) Add a link or button to the list interface from the borrower result screen? Add a link or button to delete a list from a displayed list - (patron_lists/list.pl?patron_list_id=10 for example) The ability to export the contents of a patron list as CSV. Even cooler if you could choose which fields to export - I'm thinking of a method by which librarians could, without using saved reports, get a list of borrowers to email, for example. (I know! I know. Scope creep. Just writing it down so the idea doesn't get lost. :)) Functionally this works great - I'm still having trouble with the tests though: devlibrary-koha@wingardium-leviosa:/home/liz/koha-src/koha$ prove t/db_dependent/PatronLists.t t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_devlibrary`.`patron_lists`, CONSTRAINT `patron_lists_ibfk_1` FOREIGN KEY (`owner`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO patron_lists ( name, owner) VALUES ( ?, ? )" with ParamValues: 0='Test List 1', 1=1] at Koha/List/Patron.pm line 121 # Looks like you planned 9 tests but ran 2. # Looks like your test exited with 255 just after 2. t/db_dependent/PatronLists.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 7/9 subtests Test Summary Report ------------------- t/db_dependent/PatronLists.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 9 tests but ran 2. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.52 cusr 0.02 csys = 0.57 CPU) Result: FAIL Of note, and possibly extremely relevant, is that my failure results came from an *upgraded* database, and not a fresh one. All tests pass on a fresh database with only the sample data. I'm putting this in failed qa only because I'd like an answer about the upgraded DB tests - assuming that is all ok, I'm happy to sign off on this as-is. Thanks for your continued work, Liz -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
