https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41934
--- Comment #7 from Laura Escamilla <[email protected]> --- (In reply to Brendan Lawlor from comment #5) > I tried to test this out but got a sha1 error, so I could not apply the > patch. > > A couple other things I think this would need for better accessibility is > the +/- element should probably be a <button> element and have aria-expanded > attribute set to false initially and updated to true when the notes expand. > It should have an aria-controls attribute that refers to the the id of the > notes element that is expanded. Thanks, I agree those would be worthwhile accessibility improvements. For this patch, I was aiming to address the empty table header issue specifically. Since the expand/collapse control is generated through DataTables responsive behavior, converting it to a button with aria-expanded and aria-controls would be a broader change than this bug currently covers. I think that would be better tracked as a follow-up bug so this patch can remain focused on the empty header fix. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
