https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <[email protected]> --- 1) QA tools There is a fail that looks real - can you please check? [FAIL] koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl FAIL xml_valid 690: parser error : Opening and ending tag mismatch: for-each line 657 and a 703: parser error : Opening and ending tag mismatch: span line 656 and xsl:for-each 704: parser error : Opening and ending tag mismatch: if line 655 and span 705: parser error : Opening and ending tag mismatch: template line 18 and if 790: parser error : Opening and ending tag mismatch: a line 712 and xsl:for-each 791: parser error : Opening and ending tag mismatch: for-each line 710 and span 792: parser error : Opening and ending tag mismatch: span line 709 and xsl:if 1723: parser error : Opening and ending tag mismatch: if line 708 and template I tried to spot it, but failed :( 2) Breaking change? In my experience people are quite lenient cataloguing the indicators if they can get away with it - especially here where MARC is still quite a new thing and people first get in touch with it with Koha. - <xsl:for-each select="marc:datafield[@tag=130]|marc:datafield[@tag=240]|marc:datafield[@tag=730][@ind2!=2]"> + <xsl:for-each select="marc:datafield[@tag=130]|marc:datafield[@tag=240]|marc:datafield[@tag=730][@ind2=2]"> This means that 730 with no second indicator will disappear from OPAC view, basically turning around what we did before. Is this strictly necessary? I am not quite sure how the documentation is to be understood in terms of OPAC visibiliy. https://www.loc.gov/marc/bibliographic/bd730.html Second Indicator - Type of added entry Distinguishes between an analytical entry and no information provided. ... 2) Problems in testing 130/30 I have had a look and have maybe an idea of what could have gone wrong in testing: I had assumed at first that the title should go in $t, but after studying the MARC documentation, I see that it's different in these cases: https://www.loc.gov/marc/bibliographic/bdx30.html $a - Uniform title Parenthetical information added to make a title distinctive is not separately subfield coded except in the case of the date of signing added to a uniform title of a treaty (see description of subfield $d). $t - Title of a work Title page title of a work. Subfield $t is _unlikely to be used_ in an X30 field. But this means the test plan needs to be adjusted: "This patch updates both intranet and OPAC XSLT files to check for the presence of subfield $t and use title search (ti,phr:) instead of author search (au:) when $t is present." -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
