http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |[email protected] --- Comment #12 from Galen Charlton <[email protected]> --- I have concerns about the implementation of this -- in particular, for a bib that is /not/ going to end up hidden, the acts of retrieving all of the items and checking which ones are hidden occur /twice/. In my opinion, this is likely to impose too high of a performance penalty for typical OPACs, which don't have high numbers of hidden items. I suggest revising the patch so that rather than adding a call to GetHiddenItems(), the bailing-out occurs after the original call to GetHiddenItems(). Additional refactoring might be called for (but as the topic of a separate bug) to minimize the processing gets wasted whether or not the bib ends up hidden. Also, I'm not a fan of the notion of using 0 as a "magic" biblionumber -- to bail out, just issue the redirect. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
