https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29016
--- Comment #50 from Kyle M Hall (khall) <[email protected]> --- Created attachment 198851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198851&action=edit Bug 29016 [25.11.x]: (QA follow-up) Render embedded patron, fix JS i18n drift QA review pointed out three regressions and a label gap in the new DataTable-driven log viewer: 1. The Librarian column showed a bare borrowernumber linked to the patron page; the old server-side template showed the librarian's full name with the borrowernumber in parentheses. 2. The Object column for MEMBERS / CIRCULATION / FINES / APIKEYS rows showed only the borrowernumber; the old template showed the patron's full name and used "API keys for <name> (<id>)" wording. 3. Several user-visible strings in renderObject() were hard-coded English ("Bibliographic record ", "Subscription ", "Authority ", "Basket ") and would never have been picked up by the translator. 4. The form's Actions list still includes RESTORE but the new str/viewlog.inc action_labels map missed the corresponding entry, so the rendered Action cell fell through to escapeHtml("RESTORE") instead of the localised "Restore". This patch: * Asks the API to embed both `librarian` and `patron` and uses those objects when rendering the Librarian and Object columns. When the embed is absent (e.g. because the relation does not match for a non-MEMBERS row) the renderers fall back to the bare id, preserving backwards compatibility. * Wraps the four hardcoded strings in __() with %s placeholders so the translator extracts them. The Basket markup is also assembled via __("Basket %s").format(...) rather than string concatenation so that translators can re-order the link text. * Adds RESTORE: _("Restore") to str/viewlog.inc. Test plan: 1. Tools -> Log viewer with various modules selected. 2. Verify the Librarian column shows "Firstname Surname (id)" and links to the moremember page. 3. Filter to MEMBERS / CIRCULATION / FINES; verify the Object column shows the patron's full name, and the API keys row uses the "API keys for <name> (<id>)" wording. 4. Filter to CATALOGUING / SERIAL / AUTHORITIES / ACQUISITIONS; verify "Bibliographic record N", "Subscription N", "Authority N" and "Basket N" still link correctly. 5. Restore a deleted biblio (CataloguingLog must be on); verify the Action column shows "Restore" rather than "RESTORE". Signed-off-by: Lucas Gass <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
