https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40445
--- Comment #167 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 198869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198869&action=edit Bug 40445: (follow-up) Clarify cashup summary cash row wording and sign A cashup is the process of removing cash from the till to send it to the bank, so labelling the headline cash line "Cash added to register" was confusing. Re-word it to "Cash removed from register" in the typical case and "Cash added to register" in the edge case where the cashier has had to top up the till to cover refunds. While doing this, align the sign convention of total_grouped with that of the overall total field on the summary: positive means cash collected (i.e. removed from the register at cashup time), negative means cash had to be added back into the register. Previously total_grouped used the raw accounting sign (credits negative, debits positive), so a typical $2 cash session would display "Total: 2.00" and "Cash added to register: -2.00", which was internally inconsistent. The conditions on the cash and other-payment-type rows in cashup_modal.js are swapped to match the new convention. Test plan: 1. Apply the patch and rebuild JS (yarn js:build) inside KTD. 2. As a staff user with permission to manage cash registers, take payments via several payment types (some cash, some not). 3. Trigger a cashup and view the cashup summary modal. 4. Confirm the "Total" line and the per-payment-type lines all display as positive amounts in the typical "money was collected" scenario, with the cash row labelled "Cash removed from register". 5. Issue some refunds large enough to exceed cash collected, then cash up again. 6. Confirm the cash row is labelled "Cash added to register" with a negative amount and the per-non-cash-type rows are labelled "{type} to add" where applicable. 7. Run prove t/db_dependent/Koha/Cash/Register/Cashup.t and prove t/db_dependent/Koha/Cash/Register.t inside KTD; both should pass. Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Andrew Fuerste Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
