https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41950

--- Comment #31 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
(In reply to Jonathan Druart from comment #30)
> My concern is to know how we will prevent new +count occurrences that won't
> have the corresponding dbic relation (i.e. how do we write an xt test for
> that, what I tried but failed).

Yeah, I'm trying too and don't like the results. It's always a bit fragile.

> And how do we document that, how the consumers can know if they can sort on
> it or not?

On QA I always enforce the relationship name. There are some old ones and some
I didn't QA myself. I've just added two coding guidelines:

*
https://wiki.koha-community.org/wiki/Coding_Guidelines#.5BDRAFT.5D_PERL15.1.2:_DBIC_relationship_naming
*
https://wiki.koha-community.org/wiki/Coding_Guidelines#.5BDRAFT.5D_PERL15.1.3:_Filtered_relationships_.28coderef_conditions.29

Those rules I'm pushing to the handbook as well.

PS: I wanted them voted but the meeting was over when I was done.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to