https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972
--- Comment #37 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 199123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199123&action=edit Bug 35972: (follow-up) QA and testing fixes Address QA warnings and feedback on the patch series: * opac-thesis-{tables,table-details}.tt: drop the staff-only columns_settings.inc include (caused "file error" in OPAC) and switch to the kohaTable + TablesSettings.GetTableSettings pattern used by opac-course-reserves.tt. Also drop the bogus Asset.css("css/datatables.css") reference and the obsolete title-string class (bug 27934), and add a dtr-control column for responsive expand. * admin/columns_settings.yml: register thesis_tables_table and thesis-table-items-table. * opac/opac-thesis-{tables,table-details}.pl: https:// for the GPL URL, drop debug => 1 and authnotrequired => 1 (bug 24663). * atomicupdate/bug_35972.pl: chmod +x for file_permissions QA. * mandatory/auth_val_cat.sql: register the CR_TYPE category so fresh installs don't fail the FK constraint when populate_db.pl loads auth_values.yml. * t/db_dependent/CourseReserves.t: use $builder->build_sample_biblio instead of AddBiblio($record, ''). Test plan: 1. Fresh ktd up succeeds, no FK errors on auth_values.yml. 2. Apply patches, updatedatabase, restart_all. 3. OPAC "Research tables" loads and the items detail page renders. 4. koha-qa.pl reports no forbidden_pattern / file_permissions hits. 5. prove t/db_dependent/CourseReserves.t -> 27/27 pass. Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
