https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38361

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
  Text to go in the|                            |This fixes the gender field
      release notes|                            |for the patron
                   |                            |self-registration form so
                   |                            |that if it is marked as
                   |                            |mandatory using the
                   |                            |PatronSelfRegistrationBorro
                   |                            |werMandatoryField system
                   |                            |preference, the form shows
                   |                            |the field as "Required".
                   |                            |
                   |                            |It also replaces the radio
                   |                            |buttons with a dropdown
                   |                            |menu.

--- Comment #4 from David Nind <[email protected]> ---
Suggestions for the patch so that it better matches the commit message
guidelines (https://wiki.koha-community.org/wiki/Commit_messages):

Bug 38361: Include 'Required' if patron self-registration form gender field is
mandatory

Fixes the gender field for the patron self-registration form so that if it is
marked as mandatory (PatronSelfRegistrationBorrowerMandatoryField system
preference), the form shows the field as "Required".

It also replaces the radio buttons with a dropdown menu.

Test plan:
1. For the PatronSelfRegistrationBorrowerMandatoryField system preference,
   set the Gender (sex) field as required.
2. Go to the self registration form in the OPAC and note that there is no
   'Required' label for the gender field (use a private/incognito window).
3. Attempt to submit the form (complete the other marked required fields)
   and note:
   - the gender field uses radio buttons
   - that you can't successfully submit the form without selecting a gender,
     even though there is no indication that it is required
4. Apply the patch and repeat steps 2-3.
5. Note that the gender field is now:
   - Marked as required
   - It now uses a dropdown list
6. Make sure you can successfully submit the form.
7. Set the Gender (sex) field as not required for the 
   PatronSelfRegistrationBorrowerMandatoryField system preference.
8. Make sure you can successfully submit a self-registration without 
   needing to complete the gender field.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to