https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42646
Bug ID: 42646
Summary: ModSuggestion: SMS status-change notices always
contain email template content
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
In C4/Suggestions.pm, ModSuggestion() selects the transport type (email or
sms) at ~line 253 and stores it in $transport, but then calls
GetPreparedLetter() at ~line 256 without passing message_transport_type.
GetPreparedLetter() defaults message_transport_type to 'email' when the
parameter is absent (C4/Letters.pm ~line 585), so it always fetches the
email template variant of the notice รข even when $transport was resolved to
'sms'. The result is that any patron who legitimately receives an
ACCEPTED/AVAILABLE/REJECTED/ORDERED/CHECKED notice via SMS receives the
email-formatted body text rather than the SMS-specific template content.
Related to: Bug 39984, Bug 42645
Test plan:
1. Configure SMSSendDriver and a patron with smsalertnumber but no email.
2. Enable FallbackToSMSIfNoEmail.
3. Create SMS-specific templates for the ACCEPTED notice code
(Notices > ACCEPTED > SMS tab).
4. Submit a suggestion as that patron and accept it.
5. Check the message_queue table: the content column will contain the
email template body, not the SMS template body.
6. Apply patch (add message_transport_type => $transport to the
GetPreparedLetter() call in ModSuggestion).
7. Repeat: the content column now contains the SMS template body.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
