https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40901

--- Comment #119 from Martin Renvoize (ashimema) 
<[email protected]> ---
Created attachment 199457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199457&action=edit
Bug 40901: (QA follow-up) koha-disable must disable units even when stopped

On systemd, koha-disable gated both --stop and --disable behind
is_*_running checks (systemctl is-active).  A service that was enabled
but not currently active (e.g. stopped for maintenance) was therefore
never disabled, leaving its unit enabled and able to restart on the next
boot — so the instance was never truly disabled.

Separate the concerns: keep the is_*_running guard around --stop (so we
don't try to stop an already-stopped service), but call --disable
unconditionally for plack, zebra, indexer, and es-indexer.  The disable
call is idempotent on both systemd and SysV, so calling it on an already-
disabled unit is safe.

SIP was already handled correctly (using is_sip_enabled).  Worker units
already used || true so were unaffected.

Signed-off-by: Martin Renvoize <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to