https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
--- Comment #683 from ChloƩ Zermatten <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #679) > > So the RM will not apply this patch and will regenerate & commit the schema > > files themselves. > > The following commit will cause a conflict and should be squashed with the > "DBIC Schema update" one: Bug 10190: (QA follow-up) add new line at end of > MessageTransportType.pm > > > ------ > > > The QA script report this: > > [FAIL] > koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/ > TriggerContext.vue > FAIL git_manipulation > The file has been added and deleted or renamed in the same > patchset > > Indeed, through the patchset it was created, modified and deleted ^^" > > > --- > > > The test plan should have the commands to run all the relevant tests > > > ---- > > I somehow still have that error >_< > # Failed test 'Expected permissions generated for superlibrarian' > # at t/Koha/Auth/Permissions.t line 315. > # Structures begin differing at: > # $got->{CAN_user_parameters_manage_circ_triggers} = '1' > # $expected->{CAN_user_parameters_manage_circ_triggers} = Does not > exist > > I applied the patches on current main, started a MARC21 KTD (recent image) > on Debian 12 (bookworm) on mariadb 10.11. And ran: > prove t/Koha/Auth/Permissions.t > > What else should I check? > > -- > > And a bunch cypress tests fail > > cypress run --config video=false --spec > t/cypress/integration/Admin/CirculationTriggers_spec.ts > https://paste.evolix.org/ > ?e51bc9bd243787e5#aKPWW8uYFYC5JGmpf4ZTLiCAQnue7HgH2nTvNHJF2RG I'll take the bit I can address here for now: the cypress tests :) I've played around with those a fair bit - seems a lot of the failures had to do with not quite waiting for the data to load ? And some of it was tests still expecting old strings that have been updated. That's sorted now (famous last words). Also added to the existing suite for added coverage. Last I ran them they all passed, so fingers crossed it'll stay that way! :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
