https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307

Pedro Amorim (ammopt) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |k
             Status|Passed QA                   |Failed QA

--- Comment #12 from Pedro Amorim (ammopt) <[email protected]> ---
Hi guys the patch looks solid and simple but in order to follow the test plan I
had to change the hardcoded PERSON_NAME to 'EDITORS' otherwise the authority
doesn't show when using the 210$c value builder plugin:

index 61656cf569d..4c5fc76c154 100644
---
a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt
+++
b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt
@@ -22,7 +22,7 @@
         <input type="hidden" name="type" value="intranet" />
         <input type="hidden" name="nbstatements" value="[% nbstatements | html
%]" />
         <input type="hidden" name="index" value="[% index | html %]" />
-        <input type="hidden" name="authtypecode" value="PERSO_NAME" />
+        <input type="hidden" name="authtypecode" value="EDITORS" />


----

I also had to run the following SQL manually to inject the subfield or else
trying to 'View MARC structure' on the newly created authority type results in
a server error:

    INSERT INTO auth_tag_structure (authtypecode, tagfield, liblibrarian,
libopac, repeatable, mandatory)
    VALUES ('EDITORS', '200', 'Heading', 'Heading', 0, 1);

    INSERT INTO auth_subfield_structure (authtypecode, tagfield, tagsubfield,
liblibrarian, libopac, repeatable, mandatory, tab, hidden, linkid, 
  frameworkcode, display_order)
    VALUES ('EDITORS', '200', 'b', 'Part of name', 'Part of name', 0, 0, 0, 0,
0, '', 0);

----

Failing QA to get some comments here.

Additionally, in order to be able to to test UNIMARC properly, had to launch
ktd as follows:
KOHA_MARC_FLAVOUR=unimarc ktd up

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to