https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41898
--- Comment #15 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 200093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200093&action=edit Bug 41898: Introduce 'issued' status and update booking display/filtering Implements a 4-state booking lifecycle: new → issued (on checkout) → completed (on return), plus cancelled at any point. Backend changes: - AddIssue sets booking status to 'issued' (was incorrectly 'completed') - AddReturn transitions 'issued' → 'completed' via booking_id on the issue - filter_by_active updated to status-based: status IN ('new', 'issued'); previously it filtered by date range — active/inactive now reflect booking lifecycle rather than the current date relative to start/end dates - _is_final_status_transition reverted to only skip clash detection for terminal statuses 'cancelled' and 'completed'; 'issued' is active and does not bypass clash detection - GET /api/v1/bookings no longer pre-filters to active bookings server-side; callers must supply an explicit status filter if they need active-only Display changes: - Patron bookings tab: replaces the date-based expired/active toggle with per-status filters (completed, cancelled) using the AdditionalFilters framework; active bookings (new/issued) are shown by default - Biblio bookings list: same status-based filters; removes the date-based expired filter that was still present - Status column is always visible on both views (was previously hidden on the patron tab unless expired bookings were shown) - Status badges: new=bg-success, issued=bg-info, completed/cancelled=bg-secondary - Timeline isActive check corrected to ['new','issued'] - patron-detail-tabs.inc: rename expired_bookings_count → closed_bookings_count to reflect status-based (not date-based) counting - Filter button colour fixed to use $link-color so both views are consistent Test plan: 1. Enable the EnableBookings system preference. 2. Create a biblio with at least one bookable item. 3. Place a booking for a patron via the biblio's Bookings tab. - The booking should appear with status badge "New" (green). 4. Check out the booked item to that patron (Circulation → Check out). - Reload the Bookings tab; the booking should now show "Issued" (blue). 5. Return the item (Circulation → Check in). - Reload the Bookings tab; the booking should now show "Completed" (grey). 6. Place a second booking and cancel it from the Bookings tab Actions menu. - The booking should show "Cancelled" (grey), with the reason if provided. 7. On the biblio Bookings tab: - Completed and cancelled bookings are hidden by default. - Clicking "Include completed" shows completed bookings. - Clicking "Include cancelled" shows cancelled bookings. - Both can be toggled independently. - The Status column is always visible. 8. Navigate to the patron's detail page → Bookings tab. - Active bookings (new/issued) are shown by default. - Completed and cancelled can be toggled independently using the same filter buttons. - The Status column is always visible. 9. Confirm via the REST API that GET /api/v1/bookings (no filters) returns bookings of all statuses, not just active ones. Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
