https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42799
--- Comment #1 from Jonathan Druart <[email protected]> --- Created attachment 200128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200128&action=edit Bug 42799: Fix sticky behavior by using a sentinel node Highlighted by the Cypress upgrade (bug 42772): the sticky element is always visible and IntersectionObserver rely on the visibility of the element. Cypress test Toolbar_spec.ts use scrollTo("bottom") to test the behaviour of the sticky toolbar. We test that the "floating" class is correctly added to the element. To do that we rely on IntersectionObserver that will check the visibility of the element. But the sticky element is always visible. I actually do not recreate the problem when using the UI but the current code may be broken in some browsers (or new/future versions). To fix this problem we insert a new "sentinel" element into the DOM and rely on its visibility to toggle the "floating" class. Test plan: Confirm that the sticky toolbar behaviour is the same after this patch is applied, ie. that the "floating" class is added when we scroll down. On top of bug 42772 confirm that the following command passes (run it several times): yarn cypress run --spec t/cypress/integration/Toolbar_spec.ts QA: Note that the apply_sticky function takes only one node in parameter, that's why it has been renamed nodes => node -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
