https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41410
--- Comment #28 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 200344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200344&action=edit Bug 41410: (follow-up) Fix local_holdgroup_match set incorrectly by LocalHoldsPriority local_holdgroup_match was being hardcoded to 1 in the two LocalHoldsPriority allocation paths (GiveLibrary and GiveLibraryGroup), regardless of whether the chosen item actually satisfied the LocalHoldsExclusivity conditions. This caused staff to be directed to pull an item that would not trigger the hold at checkin when the two features used different patron/item controls. The fix removes the premature local_holdgroup_match => 1 from both LHP paths and lets _flag_local_holdgroup_matches evaluate all allocated items using the correct LocalHoldsExclusivity* sysprefs. Also fixes a pre-existing missing bind-variable placeholder in the INSERT INTO tmp_holdsqueue statement (17 columns, only 16 ?). Test updates: - Existing local_holdgroup_match test gains the matching LocalHoldsExclusivity sysprefs so the flag is set via the correct code path. - New subtest reproduces the reported bug: LHP (HomeLibrary/homebranch) targets a non-local item while exclusivity (PickupLibrary/holdingbranch) should not flag it — confirms local_holdgroup_match is 0 after the fix. Signed-off-by: Trevor Diamond <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
