https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503
Lucas Gass (lukeg) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Lucas Gass (lukeg) <[email protected]> --- A couple questions, not necessarily blockers: 1. In CreatePicklistFromItemMap, do we need to fetch the itype_description, ccode_description, and location_description each time through the loop? 2. Should these fallback to code, or undef, in the cases of no description? my $ccode_description = Koha::AuthorisedValues->get_description_by_koha_field( { kohafield => 'items.ccode', authorised_value => $item->ccode } )->{lib}; 3. What is $context in this ... context? sub api_query_fixer { my ( $self, $query, $context, $no_quotes ) = @_; return Koha::Biblios->new->api_query_fixer( $query, 'biblio', $no_quotes ); } Blocker: 1. Setting HidePatronName to 'Don't show', the patron name still appears in the holds queue! 2. Schema changes to Result/TmpHoldsqueue.pm should be move to their own patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
