https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42879
Bug ID: 42879
Summary: Avoid per-record plugin lookup in ES
marc_records_to_documents
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Target Milestone: ---
marc_records_to_documents invokes
Koha::Plugins->call('elasticsearch_to_document',
...) once per record. Each call discovers the plugins implementing the hook,
which runs a query against plugin_data -- even when no plugin implements the
hook
or plugins are disabled.
In a batch reindex this is one extra query per record purely to discover there
is
nothing to call.
The set of implementing plugins is constant for the batch. Resolve it once (or
short-circuit when plugins are disabled / none implement the hook), then
dispatch
per record.
Test plan:
1. prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t
2. With a plugin implementing elasticsearch_to_document, confirm the hook still
fires for every record.
3. Count DB statements during a batch reindex before/after.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
