https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35142
--- Comment #9 from Martin Renvoize (ashimema) <[email protected]> --- One last thing.. which I think is a bit more open to discussion: DRY: the new get_normalized_oclc inlines s/^\([^)]*\)\s*//, which is byte-for-byte identical to the surviving Koha::Util::MARC::strip_orgcode, and inlines /OCoLC/i, which was the removed OCLC_REGEX. The removed Koha::Util::MARC::oclc_number already expressed exactly this as strip_orgcode(scalar find_marc_info({... match => qr/OCoLC/i})). Reusing those tested helpers would keep a single source of truth rather than re-duplicating the logic the patch set out to de-duplicate. But, the counter-argument is that the inlined version is self-contained and readable.? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
