https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42697
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Jonathan Druart <[email protected]> --- (In reply to Lucas Gass (lukeg) from comment #10) > (In reply to Jonathan Druart from comment #3) > > No, that's not correct. If you search for "bea" in the global search you do > > not longer see items from Bearchville. > > I also expect some Cypress tests to fail. > > I uploaded a new patch that works better with global search. > > Yes, KohaTable/Holdings_spec.ts is now failing. I am pretty sure that the bug is in datatables.js. Please have a look at the revert patch I've just attached, apply it and make sure the new js file is fetched by the browser (use a private window). For me it does fix the problem :) However I think I understood the problem from bug 39011 comment 17 (that this commit was trying to fix). And I think the correct fix is to have a dropdown list for all the columns linked with coded values (what you suggested on bug 39011 comment 17!) I would like to highlight bug 39011 comment 19: ``` I have not tested it a lot, I am a bit hesitant to change the core of our datatable code without providing Cypress tests. But unfortunately I don't have time right now to provide them. ``` This is from me... Time should not be a reason to not provide tests. Any changes to datatables.js MUST be covered by tests ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
