https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41265
--- Comment #4 from Katrin Fischer <[email protected]> --- (In reply to Katrin Fischer from comment #3) > Looking at this, I have some questions: > > 1) As this makes a change to Patrons.pm, could/shoudl we have a unit test > highlighting the effect of the change? > > 2) You check for the length using length() - I haven't found any other > occurrences of this in the templates which made me wonder. Should we not > just check if the value is > 0? > > length($no_issues_charge_guarantees) > 0 > vs. > $no_issues_charge_guarantees > 0 ... 0 might also make sense to block. So forget that suggestion. Looking at the code, the common check seems to be != "" git grep "!= ''" *.tt -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
