https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35797
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #36 from David Nind <[email protected]> --- Failed QA as the tests don't pass: prove t/db_dependent/api/v1/patron_images.t t/db_dependent/api/v1/patron_images.t .. # Failed test '403 Forbidden' # at t/db_dependent/api/v1/patron_images.t line 73. # got: '404' # expected: '403' # Failed test 'exact match for JSON Pointer "/error"' # at t/db_dependent/api/v1/patron_images.t line 73. # got: 'Patron image not found.' # expected: 'Patron images are disabled.' # Looks like you failed 2 tests of 19. t/db_dependent/api/v1/patron_images.t .. 1/2 # Failed test 'Image tests' # at t/db_dependent/api/v1/patron_images.t line 122. # Looks like you failed 1 test of 2. t/db_dependent/api/v1/patron_images.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/api/v1/patron_images.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=2, 5 wallclock secs ( 0.02 usr 0.01 sys + 4.45 cusr 0.35 csys = 4.83 CPU) Result: FAIL Also, the qa script complains: [FAIL] Koha/REST/V1/Patrons/Image.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/REST/V1/Patrons/Image.pm` [PASS] api/v1/swagger/paths/patrons_image.yaml [PASS] api/v1/swagger/swagger.yaml [FAIL] t/db_dependent/api/v1/image.t FAIL git_manipulation The file has been added and deleted or renamed in the same patchset SKIP new_line_at_the_end_of_file [FAIL] t/db_dependent/api/v1/patron_images.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/api/v1/patron_images.t` Testing notes (using KTD): 1. OAuth 2.0: 1.1 Enable RESTOAuth2ClientCredentials system preference 1.2 Go to a patron (for example, koha) > More > Manage API keys 1.3 Generate a new client id/key pair 1.4 Record the details 1.5 In API tool, such as Bruno, record for OAuth 2.0 authentication options: . Access Token URL: http://127.0.0.1:8080/api/v1/oauth/token . Client ID: from details recorded . Client Secret: from details recorded -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
