https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42292
--- Comment #28 from Jan Kissig <[email protected]> --- Created attachment 200913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200913&action=edit Bug 42292: (follow-up) Rename opac-shelves print flag to avoid shadowing window.print The port declares `var print = [% print ? 1 : 0 | html %];` at the top of the tt-allowed block, then later calls `window.print()` inside `if (print) { ... }`. Declaring `var print` at top-level overwrites the built-in `window.print` with 0 or 1, so the subsequent `window.print()` call throws "print is not a function" and the print view never fires its actual print dialog. Rename the flag to `should_print` and update the single `if (print)` check accordingly. To test: - Open a public list with items in the OPAC. - Click "Print this list" (or load the page with op=print). - The browser print dialog opens and the window closes afterwards. - No "print is not a function" error in the console. Signed-off-by: Paul Derscheid <[email protected]> Signed-off-by: Jan Kissig <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
