https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42444
Tomás Cohen Arazi (tcohen) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #23 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Jonathan Druart from comment #20) > 1. Not blocker but I would have expected the tab content to be loaded on > demand. I prefer to load them while staff is looking at the initial tab. But I noticed the way I tied the tab title (which includes totals) to the API response produces a flicker. I will fix it by preloading the totals from the pl controller. > 2. "Cancel all" cancels everything, without confirmation > Also note that "Cancel hold" (in the "Actions" column) does not trigger a > confirmation, but "Cancel selected" does (asking for a reason) That's the original behavior! I can add it a confirmation modal with the reason dialog! > 3. We usually use escape_str instead of escapeHtml, because it takes care of > null values. > return (data || "").escapeHtml(); > > Note that here you also remove "0", when escape_str deals with it correctly. 100% agreed. > Also note that there are variables not escaped in the last column ("Actions") > > 4. Instead of: > ``` > let cols = [{ stuff }]; > if (condition) { > cols.push({other_stuff}); > } > cols.push({yet_another_stuff}); > ``` > I would suggest: > let cols = [ > {stuff}, > ...(condition ? [{other_stuff}] : []} > {yet_anot_erstuff}, > ]; > > Of course not blocker, but I have used it extensively in the different > patches still in the queue (42278, 42332, etc.) Will do my best to rewrite that. I like the spread operator. > 5. data: "patron.surname", > Then search on firstname does not work Oops, my bad. > 6. Search on library names in the global search does not work. (search for > coded_values and filters_options in > includes/html_helpers/tables/items/catalogue_detail.inc or > includes/patron-search.inc for examples). Right. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
