https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215

--- Comment #2 from Caroline Cyr La Rose <[email protected]> ---
I was coming to bugzilla to file this again! The faulty line was moved from
C4/Items.pm to Koha/Item.pm. It appears twice in that file

https://git.koha-community.org/Koha-community/Koha/src/commit/c355bb8574f62e4a04e774a65a6385feb9b858b0/Koha/Item.pm#L1842

                my $credit;
                if ( $credit_total > 0 ) {
                    my $branchcode = C4::Context->userenv ?
C4::Context->userenv->{'branch'} : undef;
                    $credit = $account->add_credit(
                        {
                            amount      => $credit_total,
                            description => 'Item found ' . $self->itemnumber,
                            type        => 'LOST_FOUND',
                            interface   => C4::Context->interface,
                            library_id  => $branchcode,
                            item_id     => $self->itemnumber,
                            issue_id    => $lost_charge->checkout ?
$lost_charge->checkout->issue_id : undef,
                        }
                    );


https://git.koha-community.org/Koha-community/Koha/src/commit/c355bb8574f62e4a04e774a65a6385feb9b858b0/Koha/Item.pm#L2002

                my $credit;
                if ( $credit_total > 0 ) {
                    my $branchcode = C4::Context->userenv ?
C4::Context->userenv->{'branch'} : undef;
                    $credit = $account->add_credit(
                        {
                            amount      => $credit_total,
                            description => 'Item found ' . $self->itemnumber,
                            type        => 'PROCESSING_FOUND',
                            interface   => C4::Context->interface,
                            library_id  => $branchcode,
                            item_id     => $self->itemnumber,
                            issue_id => $processing_charge->checkout ?
$processing_charge->checkout->issue_id : undef,
                        }
                    );

I would remove it myself, but I was told years ago that a change to a .pm file
required tests and I don't know how to write those...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to