https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #71 from Jonathan Druart <[email protected]> --- There are some things that are not done correctly here. 1. JS variables not escaped 2. Global search not working. Reported on bug 42915 for the patron but there is also the date and the library. 3. Use of $.ajax directly, now the use of HttpClient is required (see js/fetch/*) 4. "Loading..." not translatable 5. Tests are missing (for embeds). Cypress tests should be provided for such big UI change. Not sure the changes to Koha::Hold->store (and _set_default_expirationdate) are covered by test. 6. What's that for? 1318 language: { 1319 infoFiltered: "", 1320 }, -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
