https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332

--- Comment #32 from Jonathan Druart <[email protected]> ---
(In reply to David Nind from comment #31)
> How to test?

Not easy to be exhaustive, but I will try to write something. 

We are fixing a lot of bugs here, column's visibility related.

* admin/categories
Columns "Messaging", "Check previous checkout?" and "Can place ILL in OPAC?"
depends on syspref (respectively EnhancedMessagingPreferences,
CheckPrevCheckout, ILLModule).
They must be added to the DOM, but the td should be empty and the column hidden
if they are turned off.
This is to make DT preserves the state stored in the localStorage even if one
of the syspref changes.

* catalogue/issuehistory same for column "Patron" (pref intranetreadinghistory
and permissions borrowers_view_checkout_history,
circulate_circulate_remaining_permissions)

* cataloguing/z3950_search
The column "additional_fields" was missing from the table settings yml file, so
the visibility behaviour is certainly broken.
Then column "Additional fields" depends on syspref
AdditionalFieldsInZ3950ResultSearch

* circ/overdue
Column "Return claims" depends on pref ClaimReturnedLostValue

* course_reserves/course-details
"status" missing from yaml file
Column "Item type" depends on syspref item_level_itypes and "Actions" on
permissions coursereserves_add_reserves and coursereserves_delete_reserves

* members/readingrec
"checked_out_by" missing from yml file
Column "Checked out by" depends on syspref RecordStaffUserOnCheckout

* reports/guided_reports_start
No change expected, but code adjusted to be inline with the current pattern

* reports/itemslost
First column "selection" was missing from yaml file
Its visibility depends on the existence of CSV profiles defined

* tools/inventory
First column "Seen" depends on the screen you are. Without this patch I expect
the column visibility state to not be restored correctly from one screen to
another

* tools/upload
Columns "Public" and "Temporary" are hidden if we upload files from the
cataloguing plugin "upload"

* holds-table
Column "hold-group" was missing from the yaml file
Its visibility depends on the syspref DisplayAddHoldGroups

* catalogue/detail
Table "Comments", column "Actions" depends on the permission
tools_moderate_comments

* admin/itemtypes
Extra column "lost_processing_fee" in yaml file
Column "Image" depends on noItemTypeImages and OpacNoItemTypeImages

Note that you need to `flush_memcached && koha-plack reload kohadev` so the
yaml file will be fetched from the disk (not from the cache).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to