https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42914
--- Comment #1 from Baptiste Wojtkowski (bwoj) <[email protected]> --- Created attachment 201058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201058&action=edit Bug 42914: Remove hardcoded references to 'MANUAL' restriction code. Since Bug 23681, and in particular commit 3b1c271f78bb339800fac3f4c2b11ce4900f8e6a, 'MANUAL' is not a system restriction_type that can be deleted and therefore should not be mentionned in the code. In the code it is used as a fallback systempreference, which should be the role of the one flagged is_default rather than 'MANUAL' Steps to reproduce : Do NOT apply patch until 8- 1 - Set the syspref PatronRestrictionTypes to allow 2 - In Adminitration -> PatronRestrictionType, create a new restriction type, make it default 3 - Delete the 'MANUAL' restriction 4 - Go to Tools -> Batch Patron Modifications and add a cardnumber (on ktd 42) 5 - Add a restriction expiration date 6 - Watch Koha burning 7 - Run tests t/db_dependent/Circulation.t t/db_dependent/Members.t t/db_dependent/Patron/Borrower_Debarments.t, see they are broken by the suppression of 'MANUAL' 8 - Apply patch 9 - Run the tests again 10 - Repeat 4-6 11 - Go to Henry Acevedo's page and open the edit form, add a restriction through the form -> it works ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
