https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42189
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #56 from Pedro Amorim (ammopt) <[email protected]> --- Hi all, great work. Some minor comments mostly due to bug 37762 now being in main (it wasn't when this work was first developed): 1) js/vue/dist/ill.js needs to part of 'Switch Vue module templates' commit 2) Having to set and include islands_esm_src in erm.tt when it's already been done in main-container.inc looks redundant. Please confirm. Ideally it would only be loaded once in main-container.inc (as opposed to every future new module dashboard having to explicitly also import that). 3) The original implementation added the following: module="erm" but at the time, ModuleDashboard did not have the 'name' parameter. Do we still need to add the 'module' attribute or can we now just use the existing 'name' for uniqueness purposes of widgets filtering? i.e. drop the 'module' attribute that this patchset is adding (it's redundant). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
