http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334
Bernardo Gonzalez Kriegel <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |[email protected] --- Comment #5 from Bernardo Gonzalez Kriegel <[email protected]> --- Vitor, looks promising, tested and works well AFAIK. But: 1) You must make a patch a) Verify unimarc_field_100_authorities.pl is chmoded +x b) Update licence information, you do not work for katipo :) read http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence c) do git add cataloguing/value_builder/unimarc_field_100_authorities.pl git add koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100_authorities.tt git commit -m "Bug 8334 - Authority UNIMARC 100 field plugin" d) then do git bz attach -e 8334 HEAD or git format-patch origin/master, and upload that as patch 2) But before upload, you must fix the following errors koha-qa -c 1 -v 3 testing 1 commit(s) (applied to dcbe50c 'Bug 10897: remove test for module tha') FAIL cataloguing/value_builder/unimarc_field_100_authorities.pl OK pod FAIL forbidden patterns forbidden pattern: tab char (line 124) forbidden pattern: tab char (line 119) forbidden pattern: tab char (line 118) forbidden pattern: tab char (line 122) forbidden pattern: tab char (line 117) forbidden pattern: tab char (line 121) forbidden pattern: tab char (line 123) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100_authorities.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 326) forbidden pattern: trailing space char (line 187) forbidden pattern: trailing space char (line 372) forbidden pattern: trailing space char (line 321) forbidden pattern: trailing space char (line 213) forbidden pattern: tab char (line 213) forbidden pattern: trailing space char (line 74) forbidden pattern: trailing space char (line 361) forbidden pattern: trailing space char (line 100) forbidden pattern: trailing space char (line 134) forbidden pattern: trailing space char (line 239) forbidden pattern: tab char (line 188) forbidden pattern: tab char (line 187) forbidden pattern: trailing space char (line 106) forbidden pattern: trailing space char (line 45) forbidden pattern: trailing space char (line 389) forbidden pattern: trailing space char (line 124) forbidden pattern: trailing space char (line 205) forbidden pattern: trailing space char (line 393) forbidden pattern: trailing space char (line 354) forbidden pattern: trailing space char (line 334) forbidden pattern: trailing space char (line 405) forbidden pattern: trailing space char (line 149) forbidden pattern: trailing space char (line 315) OK tt_valid OK valid_template 3) Finally, you must add a test plan to the bug description, for example a) Edit authority framework XXX, link subfield 'a' with plugin b) create a new record or edit one c) use plugin d) save 4) Question: Is there a link to valid language codes? that could be a useful. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
