https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40911

--- Comment #6 from Katrin Fischer <[email protected]> ---
Created attachment 201126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201126&action=edit
Bug 40911: Fix SIP Patron->new() warnings with undefined/empty patron_id

This patch prevents warnings when C4::SIP::ILS::Patron->new()
receives undefined, empty, or whitespace-only patron_id values
that could occur from faulty plugins or malformed SIP requests.

Changes:
- Add early validation for undefined/empty patron_id before processing
- Add validation for hashref keys to ensure they contain valid values
- Add better debug logging for empty hashref scenarios
- Prevent potential siplog formatting issues with hashref patron_id
- No functional changes - behavior preserved for valid patron identifiers

Test plan:
1. Apply the regression tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/SIP/Patron.t
=> FAIL: Tests fail! Warning validation expects no warnings but warnings occur
3. Apply this patch
4. Repeat step 2
=> SUCCESS: Tests pass! No warnings generated for invalid input
5. Verify no warnings in SIP logs for malformed requests
6. Sign off :-D

Signed-off-by: Katrin Fischer <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to