https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37502
Adolfo Rodríguez Taboada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201130|0 |1 is obsolete| | --- Comment #22 from Adolfo Rodríguez Taboada <[email protected]> --- Created attachment 201266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201266&action=edit New version of the patch with tidied up files Thanks for the sign-off, David! Regarding your comments: Tab counter (ERM (1) with multiple packages): This is intentional. The number shown in the tab label reflects the count of ERM titles linked to the bibliographic record, not the number of packages. A single title can appear in multiple packages, but what we are exposing here is the title-level link — so "ERM (1)" correctly means one ERM title is associated with this biblio. This design decision was deliberate. Tidiness failures: Fixed. The four files flagged by the QA script (Koha/REST/V1/Biblios/ERMHoldings.pm, catalogue/detail.pl, catalogue/detail.tt, ERMCatalogueTab.vue) have been run through misc/devel/tidy.pl and the changes incorporated into the patch. A new version of the patch has been uploaded. Bug 42933: Agreed that this falls outside the scope of this bug. Bug 37502 is specifically about exposing ERM holdings information in the catalogue detail view. The behaviour you described in Bug 42933 is a separate concern and should be addressed there. Greetings, Adolfo. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
