https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41297
--- Comment #19 from Kyle M Hall (khall) <[email protected]> --- Created attachment 201324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201324&action=edit Bug 41297: (follow-up) Improve system preference descriptions Rename to place the preferences adjacent to EdifactInvoiceImport on the system preferences page and align notifications preferences with conventions. - EdiBlockDuplicateInvoice -> EdifactInvoiceImportBlockDuplicates - EdiBlockDuplicateInvoiceEmailNotice -> EdifactInvoiceImportBlockDuplicatesEmailNotice - EdiBlockDuplicateInvoiceEmailAddresses -> EdifactInvoiceImportBlockDuplicatesEmailAddresses - Change EdiBlockDuplicateInvoiceEmailNotice from YesNo to Choice, matching the EmailPurchaseSuggestions/EmailAddressForSuggestions pattern. Options are: Do not send / AcquisitionsDefaultEmailAddress / specific email addresses / KohaAdminEmailAddress. - EdiBlockDuplicateInvoiceEmailAddresses is now only used when the choice is set to 'specific email addresses', matching EmailAddressForSuggestions. - Pass from_address (AcquisitionsDefaultEmailAddress with fallback) and reply_address (AcquisitionsDefaultReplyTo) to EnqueueLetter for both library and vendor notifications, consistent with other acquisitions notices. - Add UPDATE in atomicupdate to migrate existing YesNo installs to Choice. Update all references in EDI.pm, acquisitions.pref, atomicupdate, sysprefs.sql, and tests. Also fix test mock values for EmailNotice from the old YesNo value (1) to the correct Choice value ('EdifactInvoiceImportBlockDuplicatesEmailAddresses'). Signed-off-by: Hannah Dunne-Howrie <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
