https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39769

--- Comment #6 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
(In reply to Jonathan Druart from comment #5)
> We have C4::Context->disable_syspref_cache(); that is used in
> misc/batchRebuildItemsTables.pl:C4::Context->disable_syspref_cache() if (
> defined( C4::Context->disable_syspref_cache() ) );
> 
> But I would not rely on it, flushing L1 feels better here. However I feel
> like we should also do it in Koha::BackgroundJob->process, but that could be
> done on a separate bug.
> 
> > Rather, we need to clear the L1 cache after we fetch a job.
> 
> This is what I would do however, it is safer to flush right after we receive
> the frame or fetch the jobs.
> 
> Before this
> 161         my $job = Koha::BackgroundJobs->find( $args->{job_id} );
> 
> and before this:
> 200         @jobs = Koha::BackgroundJobs->search(
> 201             { status => 'new', queue => 'elastic_index' },
> 202             { rows   => $batch_size }
> 203         )->as_list;
> 
> Don't you think?

I agree

> Also I would remove the ref to the bug number in the comment, what we
> usually don't do. We have git log for that.

Yeah, fair

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to