https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43058

--- Comment #3 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 201887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201887&action=edit
Bug 43058: Clean up reserve/request.pl host items handling

reserve/request.pl imported get_hostitemnumbers_of from C4::Items but
never called it -- the code used $biblio->host_items instead. However,
it did so with an awkward two-step pattern:

    my @items = $biblio->items->as_list;
    my @host_items = $biblio->host_items->as_list;
    push @items, @host_items if @host_items;

Replace with the single idiomatic call:

    my @items = $biblio->items({ host_items => 1 })->as_list;

Test plan:
1. Apply this patch
2. Run:
   perl -c reserve/request.pl
   => SUCCESS: Syntax OK
3. Place a hold on an analytic record with EasyAnalyticalRecords on
   => SUCCESS: Host items are shown on the holds form

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to