https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43088
--- Comment #6 from David Nind <[email protected]> --- Created attachment 202119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202119&action=edit Bug 43088: Reuse _current_directory() instead of duplicating pwd() calls _change_directory(), _list_files() and _is_connected() each called $self->{connection}->pwd directly for their log payloads/connectivity check, duplicating exactly what _current_directory() now provides as a proper, documented internal accessor. Route them through it instead - no behaviour change, just removing the duplication now that the wrapper exists. Test plan: 1. prove -r t/db_dependent/Koha/File/ => All tests successful (32 tests), including the existing current_directory() and list_files()/change_directory() coverage. 2. koha-qa.pl -v 2 --more-tests => [PASS], no critic/pod warnings. Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
