https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43078
--- Comment #5 from David Nind <[email protected]> --- Created attachment 202125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202125&action=edit Bug 43078: Include longname and perms keys in FTP's NLST fallback listing The MLSD path, SFTP, and Local always return all six documented list_files() keys (filename, longname, size, perms, mtime, type) - undef where the value is unknown, but the key always present. The NLST fallback path (servers without MLSD support) only set filename, size, mtime and type, omitting longname and perms entirely rather than setting them to undef. Functionally harmless for consumers reading $file->{perms} (Perl returns undef for a missing hash key too), but it breaks the "same flat shape" contract this bug established, and would trip up any consumer using exists() instead of defined() to check for a key. Test plan: 1. prove t/db_dependent/Koha/File/Transport/FTP.t => All tests successful, including the new assertion that longname and perms keys are present (as undef) on the NLST fallback path. 2. koha-qa.pl -v 2 --more-tests => [PASS], no critic/pod warnings. Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
