http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] | |m --- Comment #7 from Jonathan Druart <[email protected]> --- (In reply to Katrin Fischer from comment #6) > Wow - this is huge! Yes, it is. Jesse, do you think it is possible to divide this patch into smaller ones? Creating many iterations will help moving ahead this patch. This patch does not apply anymore, so I just look at the code. Here are some notes: 1/ Use qa-tools in order to flush out some wrong lines (e.g. Koha is under the GPLv3 license, not v2). 2/ my $hours = { %{ $self->get_hours( $dt ) } }; is not it the same as $self->get_hours( $dt ) ? 3/ IN DUPLICATE is a Mysqlism. 4/ in updatedb: use a transaction to avoid a lost of data. 5/ Please use "git mv" for renaming files (e.g. tools/holidays.tt and tools/calendar.tt). The changes in the git history will be easier to read. 6/ try to provide several small patches (if possible). 7/ provide a more detailed test plan Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
